-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update x/gov to match module spec #4665
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4665 +/- ##
==========================================
- Coverage 54.3% 54.04% -0.26%
==========================================
Files 271 269 -2
Lines 17344 17114 -230
==========================================
- Hits 9418 9249 -169
+ Misses 7228 7179 -49
+ Partials 698 686 -12 |
To introduce the Do we want to do that or should we leave it as is? @rigelrozanski @alexanderbez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until review of proposal registration process
Co-Authored-By: colin axner <[email protected]>
Co-Authored-By: colin axner <[email protected]>
Co-Authored-By: colin axner <[email protected]>
Co-Authored-By: colin axner <[email protected]>
Co-Authored-By: colin axner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dopeness - much needed cleanup - left a few comments worth addressing
x/gov/keeper/proposal.go
Outdated
} | ||
keeper.cdc.MustUnmarshalBinaryLengthPrefixed(bz, &proposalID) | ||
proposalID = binary.LittleEndian.Uint64(bz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be consolidated to a key function per my previous comments too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: