Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update x/gov to match module spec #4665

Merged
merged 42 commits into from
Aug 8, 2019
Merged

update x/gov to match module spec #4665

merged 42 commits into from
Aug 8, 2019

Conversation

fedekunze
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #4665 into master will decrease coverage by 0.25%.
The diff coverage is 60.8%.

@@            Coverage Diff             @@
##           master    #4665      +/-   ##
==========================================
- Coverage    54.3%   54.04%   -0.26%     
==========================================
  Files         271      269       -2     
  Lines       17344    17114     -230     
==========================================
- Hits         9418     9249     -169     
+ Misses       7228     7179      -49     
+ Partials      698      686      -12

@fedekunze fedekunze requested a review from rigelrozanski as a code owner July 25, 2019 10:51
@fedekunze fedekunze requested a review from colin-axner July 25, 2019 10:51
@fedekunze
Copy link
Collaborator Author

To introduce the internal/ pkg, we'd have to move to exported/ the Content and Handler interfaces as well as NewMsgSubmitProposal, codec's RegisterProposalType(Codec), ValidateAbstract, etc.

Do we want to do that or should we leave it as is? @rigelrozanski @alexanderbez

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until review of proposal registration process

@fedekunze fedekunze added S:blocked Status: Blocked and removed S:blocked Status: Blocked labels Aug 5, 2019
@fedekunze fedekunze requested a review from alexanderbez August 6, 2019 21:15
x/gov/types/errors.go Outdated Show resolved Hide resolved
x/gov/module.go Outdated Show resolved Hide resolved
x/gov/module.go Outdated Show resolved Hide resolved
x/gov/types/tally.go Outdated Show resolved Hide resolved
x/gov/types/params.go Outdated Show resolved Hide resolved
x/gov/types/expected_keepers.go Outdated Show resolved Hide resolved
x/gov/types/expected_keepers.go Outdated Show resolved Hide resolved
x/gov/test_common.go Outdated Show resolved Hide resolved
x/gov/keeper/vote_test.go Outdated Show resolved Hide resolved
x/gov/keeper/proposal_test.go Show resolved Hide resolved
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dopeness - much needed cleanup - left a few comments worth addressing

x/gov/abci_test.go Outdated Show resolved Hide resolved
x/gov/client/rest/tx.go Outdated Show resolved Hide resolved
x/gov/client/rest/tx.go Outdated Show resolved Hide resolved
x/gov/handler.go Outdated Show resolved Hide resolved
}
keeper.cdc.MustUnmarshalBinaryLengthPrefixed(bz, &proposalID)
proposalID = binary.LittleEndian.Uint64(bz)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be consolidated to a key function per my previous comments too

.pending/breaking/store/_4665-gov-keys Outdated Show resolved Hide resolved
x/gov/types/keys.go Show resolved Hide resolved
@alexanderbez alexanderbez added the T: State Machine Breaking State machine breaking changes (impacts consensus). label Aug 8, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit e4c8bd7 into master Aug 8, 2019
@alexanderbez alexanderbez deleted the gov-internal branch August 8, 2019 19:51
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gov T: State Machine Breaking State machine breaking changes (impacts consensus). Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants