Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bank keeper by removing private funcs #4663

Merged
merged 6 commits into from
Jul 2, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Jul 2, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #4663 into master will decrease coverage by 0.02%.
The diff coverage is 74.66%.

@@            Coverage Diff             @@
##           master    #4663      +/-   ##
==========================================
- Coverage   55.06%   55.03%   -0.03%     
==========================================
  Files         273      273              
  Lines       17086    17066      -20     
==========================================
- Hits         9408     9392      -16     
+ Misses       6984     6981       -3     
+ Partials      694      693       -1

x/bank/internal/keeper/keeper.go Outdated Show resolved Hide resolved
x/bank/internal/keeper/keeper.go Outdated Show resolved Hide resolved
@fedekunze fedekunze requested a review from alexanderbez July 2, 2019 14:03
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ☕️

@alexanderbez alexanderbez merged commit 55e6b25 into master Jul 2, 2019
@alexanderbez alexanderbez deleted the refactor-bank-keeper branch July 2, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants