Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back CORS option to rest server #4622

Closed
4 tasks
okwme opened this issue Jun 25, 2019 · 3 comments
Closed
4 tasks

Add back CORS option to rest server #4622

okwme opened this issue Jun 25, 2019 · 3 comments

Comments

@okwme
Copy link
Contributor

okwme commented Jun 25, 2019

Summary

Bring back insecure CORs option for REST server but set the default option off.

#3312
#3317
#4432
#2520

Problem Definition

What problems may be addressed by introducing this feature?

Front end devs are not familiar with the server requirements of reserve proxy and nginx in order to access the REST endpoint.

What benefits does the SDK stand to gain by including this feature?

It will support front end developers better

Are there any disadvantages of including this feature?

It would slightly increase the chance that someone may misconfigure their REST server by accidentally including --insecure that would allow unsecured access.

Proposal

add an --insecure flag to the rest server that adds CORs header with Access-Control-Allow-Origin: *


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio
Copy link
Contributor

alessio commented Jun 25, 2019

Fair enough - I'm happy with the plan

@njmurarka
Copy link
Contributor

Any idea when this will happen?

@alessio
Copy link
Contributor

alessio commented Mar 3, 2020

closed in #5671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants