Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concept of shares from client-returned delegations #4190

Closed
4 tasks
alexanderbez opened this issue Apr 25, 2019 · 1 comment · Fixed by #4333
Closed
4 tasks

Remove concept of shares from client-returned delegations #4190

alexanderbez opened this issue Apr 25, 2019 · 1 comment · Fixed by #4333

Comments

@alexanderbez
Copy link
Contributor

The concept of "shares" has been removed from client facing bonding/unbonding actions (#3857). However, delegations and re-delegations still return the notion of "shares" -- they should return tokens.

Acceptance Criteria:

TODO

Shares is still a core component of both the RedelegationEntry and Delegation types. So I'm not totally sure of the best course of action here. We can add a new field, amount, but that would increase state bloat. Or, we can implement a new type just for clients that does the conversion after we fetch the objects.

/cc @faboweb @fedekunze


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@faboweb
Copy link
Contributor

faboweb commented Apr 26, 2019

I would create an only client facing type that adds the amount field.
After some versions I would even remove the shares completely from the client facing type. But only after some versions to improve upgradability.

Thx for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants