You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The concept of "shares" has been removed from client facing bonding/unbonding actions (#3857). However, delegations and re-delegations still return the notion of "shares" -- they should return tokens.
Acceptance Criteria:
TODO
Shares is still a core component of both the RedelegationEntry and Delegation types. So I'm not totally sure of the best course of action here. We can add a new field, amount, but that would increase state bloat. Or, we can implement a new type just for clients that does the conversion after we fetch the objects.
I would create an only client facing type that adds the amount field.
After some versions I would even remove the shares completely from the client facing type. But only after some versions to improve upgradability.
The concept of "shares" has been removed from client facing bonding/unbonding actions (#3857). However, delegations and re-delegations still return the notion of "shares" -- they should return tokens.
Acceptance Criteria:
TODO
Shares
is still a core component of both theRedelegationEntry
andDelegation
types. So I'm not totally sure of the best course of action here. We can add a new field,amount
, but that would increase state bloat. Or, we can implement a new type just for clients that does the conversion after we fetch the objects./cc @faboweb @fedekunze
For Admin Use
The text was updated successfully, but these errors were encountered: