Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tendermint to v0.31.3 #4029

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Update Tendermint to v0.31.3 #4029

merged 3 commits into from
Apr 3, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 2, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@liamsi
Copy link
Contributor

liamsi commented Apr 2, 2019

To fix the failing test (Test_multiSigKey_Properties), you will have to manually update the expected key there:

Index: client/keys/show_test.go
===================================================================
--- client/keys/show_test.go	(revision ce82e01ec416e6348192595e451bfd4e92eb5583)
+++ client/keys/show_test.go	(date 1554245452000)
@@ -23,8 +23,8 @@
 
 	assert.Equal(t, "myMultisig", tmp.GetName())
 	assert.Equal(t, keys.TypeMulti, tmp.GetType())
-	assert.Equal(t, "79BF2B5B418A85329EC2149D1854D443F56F5A9F", tmp.GetPubKey().Address().String())
-	assert.Equal(t, "cosmos10xljkk6p32zn98kzzjw3s4x5g06k7k5lz6flcv", tmp.GetAddress().String())
+	assert.Equal(t, "D3923267FA8A3DD367BB768FA8BDC8FF7F89DA3F", tmp.GetPubKey().Address().String())
+	assert.Equal(t, "cosmos16wfryel63g7axeamw68630wglalcnk3l0zuadc", tmp.GetAddress().String())
 }
 
 func Test_showKeysCmd(t *testing.T) {

@alexanderbez
Copy link
Contributor Author

Indeed, updated @liamsi 👍

@alexanderbez alexanderbez marked this pull request as ready for review April 3, 2019 00:34
@alexanderbez
Copy link
Contributor Author

Nothing consequential here -- merging with a single approval.

@alexanderbez alexanderbez merged commit bf17e1b into develop Apr 3, 2019
@alexanderbez alexanderbez deleted the bez/update-tm-v0.31.3 branch April 3, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants