Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON response returns code but no error message on return=sync #4013

Closed
4 tasks
fedekunze opened this issue Apr 1, 2019 · 3 comments
Closed
4 tasks

JSON response returns code but no error message on return=sync #4013

fedekunze opened this issue Apr 1, 2019 · 3 comments

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Apr 1, 2019

Summary of Bug

Broadcast POST /txs with return=sync returns error code without any message:

{
  "height": "0", // fixed according to Fabo on the next SDK release
  "txhash": "9820BFF17B54F8AD24E88902B6785A089C80AAA022371699FA1C732924129368",
  "code": 4 // unauthorized, no error_message
}

Probably it's the base error code's messages which are not returned?

https://github.com/cosmos/cosmos-sdk/blob/develop/types/errors.go

Steps to Reproduce

Couldn't reproduce anymore after I restarted the local-testnet, but probably was because of signature verification error.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Can you test with the latest develop @fedekunze? This logic was recently changed.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 17, 2020
@tac0turtle
Copy link
Member

This flow has changed with stargate. Please try reproducing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants