-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination on every REST endpoint that return list of resources #3964
Comments
I start working on this #3952 then we will probably refactor when pagination will be available on RPC side |
pagination is already available in on RPC. In gaia lite it's currently implemented on the Tx query, you can copy the logic from there. No need to reinvent the wheel ;) |
on RPC we have it for Transactions only, so yeah the same logic should be added to validators, on our side I'm not 100% is working, seems we always query page 0 cosmos-sdk/x/staking/client/rest/utils.go Line 32 in 424adf1
|
moved to #4601 |
We should be able to paginate every request that is expected to return a list of elements.
Ideally this could work in a middleware so we don't have to implement the same logic on each handler.
With @melekes we are writing the twin issue on tendermint repo: tendermint/tendermint#3472
The text was updated successfully, but these errors were encountered: