-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return the rewards amount on withdraw tx responses #3850
Comments
So we won't be able to return the amount as a result of the tx. I think we can do one of the following:
|
Can 1 and 2 results differ ? I think 2 is more accurate, right ? |
I guess it's possible but unlikely. Yes (2) would be more ideal. |
even if it's not ideal to parse the amount from the tag, I prefer to have the consistency of the amount withdrawn, so I'd go with 2. cc: @cosmos/cosmos-ui |
We can add it as a tag and return it in the actual response of the REST endpoint |
Summary
Displaying fees on clients obtained from reward withdrawal txs is not supported because the message doesn't have an
amount
field.Problem Definition
See: luniehq/lunie#2222
Proposal
return the amount withdrawn by adding it to the response message
AC:
WithdrawDelegationRewards
return the rewards withdrawnhandleMsgWithdrawDelegatorReward
to include these rewards in a tagcc: @alexanderbez
For Admin Use
The text was updated successfully, but these errors were encountered: