Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Don't store denominations in staking #3561

Merged
merged 5 commits into from
Feb 8, 2019
Merged

R4R: Don't store denominations in staking #3561

merged 5 commits into from
Feb 8, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Feb 8, 2019 •
edited
Loading

Followup from #3507
Closes #3541

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added this to the v0.31.0 (Launch RC) milestone Feb 8, 2019
jackzampolin
jackzampolin reviewed Feb 8, 2019
View reviewed changes
x/staking/types/delegation.go
@@ -113,8 +113,8 @@ type UnbondingDelegation struct {
type UnbondingDelegationEntry struct {
CreationHeight int64 `json:"creation_height"` // height which the unbonding took place
CompletionTime time.Time `json:"completion_time"` // time at which the unbonding delegation will complete
InitialBalance sdk.Coin `json:"initial_balance"` // atoms initially scheduled to receive at completion
Balance sdk.Coin `json:"balance"` // atoms to receive at completion
InitialBalance sdk.Int `json:"initial_balance"` // atoms initially scheduled to receive at completion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

jackzampolin
jackzampolin approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice perf addition with a small cost here.

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #3561 into develop will decrease coverage by 0.01%.
The diff coverage is 87.5%.

@@             Coverage Diff             @@
##           develop    #3561      +/-   ##
===========================================
- Coverage     57.3%   57.28%   -0.02%     
===========================================
  Files          179      179              
  Lines        14125    14124       -1     
===========================================
- Hits          8094     8091       -3     
- Misses        5546     5548       +2     
  Partials       485      485

@jackzampolin jackzampolin merged commit 6ee9c97 into develop Feb 8, 2019
@jackzampolin jackzampolin deleted the cwgoes/simplify-staking-coin branch February 8, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:x/staking
Projects
None yet
Milestone
v0.31.0 (Launch RC)
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @alexanderbez @jackzampolin