Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Round down when calculating rewards (fixes F1 sim bug) #3359

Merged
merged 4 commits into from
Jan 23, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 23, 2019

Closes #3354

Always round down when calculating rewards in F1 fee distribution. As far as I can tell, this fixes all the F1-related simulation issues, but I haven't yet run a long multi-seed test.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added wip C:x/distribution distribution module related labels Jan 23, 2019
@cwgoes cwgoes changed the title WIP: Debug F1 simulation issue R4R: Debug F1 simulation issue Jan 23, 2019
@cwgoes cwgoes requested a review from alexanderbez January 23, 2019 12:11
@cwgoes cwgoes changed the title R4R: Debug F1 simulation issue R4R: Round down when calculating rewards (fixes F1 sim bug) Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #3359 into jack/makefile-fix will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           jack/makefile-fix   #3359      +/-   ##
====================================================
- Coverage              54.93%   54.9%   -0.03%     
====================================================
  Files                    132     132              
  Lines                   9645    9645              
====================================================
- Hits                    5298    5296       -2     
- Misses                  4014    4016       +2     
  Partials                 333     333

@cwgoes cwgoes force-pushed the cwgoes/debug-simulation-f1-bug branch from e2813fc to e52e793 Compare January 23, 2019 13:22
@cwgoes cwgoes merged commit cd44f29 into jack/makefile-fix Jan 23, 2019
@cwgoes cwgoes deleted the cwgoes/debug-simulation-f1-bug branch January 23, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants