Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove separation of key fields from value during marshalling #3233

Closed
rigelrozanski opened this issue Jan 5, 2019 · 0 comments · Fixed by #3230
Closed

Remove separation of key fields from value during marshalling #3233

rigelrozanski opened this issue Jan 5, 2019 · 0 comments · Fixed by #3230

Comments

@rigelrozanski
Copy link
Contributor

As per several discussions, to simplify the code we should allow for duplicate fields to be stored in both the key and value of a key value pair, this is already the case in most places I believe, however we'd started decoupling these within staking. For example a validator's key uses the the validators operating address, which is also a field in the Validator object and thus also included in the value... decoupling this creates extra code maintenance (and possibility of errors) as these structs change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant