Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Bech32 encoding of an empty address #2580

Closed
sunnya97 opened this issue Oct 24, 2018 · 2 comments · Fixed by #2601
Closed

Better Bech32 encoding of an empty address #2580

sunnya97 opened this issue Oct 24, 2018 · 2 comments · Fixed by #2601
Labels
T:Bug T: UX

Comments

@sunnya97
Copy link
Member

Currently, whenever we bech32ify an empty address (whenever you use .String or .MarshalJSON) it comes out as cosmos1550dq7. Should we have this encode as an empty string instead? That way, if it's in a JSON or Amino, it can just not include that field.
@ValarDragon
Copy link
Contributor

I think this is a bug. I agree that it should encode to an empty string.

@alexanderbez
Copy link
Contributor

Agreed.

@sunnya97 sunnya97 mentioned this issue Oct 27, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug T: UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: Bech32 Empty Addresses cosmos/cosmos-sdk
3 participants
@sunnya97 @alexanderbez @ValarDragon