Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test whatever cross-compilation we expect to be doing in CI #2498

Closed
cwgoes opened this issue Oct 15, 2018 · 11 comments
Closed

Test whatever cross-compilation we expect to be doing in CI #2498

cwgoes opened this issue Oct 15, 2018 · 11 comments
Assignees
@mircea-c
Labels
S:blocked Status: Blocked T: CI T: Tests

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Oct 15, 2018

That way we'll know if we break it!

Ref https://github.com/cosmos/cosmos-sdk/pull/2215/files#r225293592
@cwgoes cwgoes mentioned this issue Oct 15, 2018
Merged
@ValarDragon
Copy link
Contributor

We are no longer planning on supporting cross compilation. We will have to use Cgo as we move towards more modern cryptography support, so doesn't make sense to temporarily support it.

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 15, 2018

OK maybe we should sync with @faboweb on that then, since I think Voyager is still using cross-compilation.

@cwgoes
Copy link
Contributor Author

cwgoes commented Dec 14, 2018

cc @mircea-c is this a thing that could happen? We need to run OS X CI basically.

@mircea-c
Copy link

Yes this should be possible. CircleCI can run jobs on an OSX machine.

@mircea-c mircea-c self-assigned this Dec 17, 2018
@mircea-c
Copy link

@cwgoes, @jackzampolin currently our CircleCI plan doesn't cover macOS: example

Need a github organization admin to enable it from CircleCI if we intend to use it. Blocked until that time.

@mircea-c mircea-c added the S:blocked Status: Blocked label Dec 17, 2018
@jackzampolin
Copy link
Member

cc @ebuchman

@ebuchman
Copy link
Member

I think I enabled it? Something might be broken on the Circle interface though

@ebuchman
Copy link
Member

it doesnt give me an option to select a MacOS plan

@mircea-c
Copy link

It's under Organization Settings -> Plan Overview.

circleci_plans

@mircea-c
Copy link

@ebuchman you may have changed the OS type under the SDK project, builds are not starting anymore 😄

@ebuchman
Copy link
Member

Lol ok. should be fixed

@mircea-c mircea-c mentioned this issue Dec 18, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mircea-c mircea-c

Labels
S:blocked Status: Blocked T: CI T: Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ebuchman @ValarDragon @jackzampolin @mircea-c @cwgoes