Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build tags from account e2e #21742

Closed
julienrbrt opened this issue Sep 16, 2024 · 1 comment
Closed

Remove build tags from account e2e #21742

julienrbrt opened this issue Sep 16, 2024 · 1 comment
Labels
C:x/accounts T: Tests

Comments

@julienrbrt
Copy link
Member

Note, the whole tests/e2e/accounts never runs in CI because of //go:build app_v1
We should delete this build tag in the future (I believe after depinject support cc @testinginprod)

ref #21725
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Sep 16, 2024
@julienrbrt julienrbrt mentioned this issue Sep 27, 2024
Closed
@akhilkumarpilli
Copy link
Contributor

Fixed with #22418

@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/accounts T: Tests
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienrbrt @akhilkumarpilli