Add show-address command #2170
Merged
Add show-address command #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2170 +/- ##
==========================================
- Coverage 63.62% 63.5% -0.13%
==========================================
Files 136 136
Lines 8270 8286 +16
==========================================
Hits 5262 5262
- Misses 2652 2668 +16
Partials 356 356 |
alexanderbez
approved these changes
Aug 28, 2018
docs/validators/security.md
Outdated
| @@ -39,3 +39,14 @@ Sentry Nodes should edit their config.toml: | |||
| # Comma separated list of peer IDs to keep private (will not be gossiped to other peers) | |||
| private_peer_ids = "ipaddress of validator nodes" | |||
| ``` | |||
|
|
|||
| ## Environment Variables | |||
There was a problem hiding this comment.
Where did this come from?
There was a problem hiding this comment.
Ohhh, Looks like this address #1973. Wanna tag that somewhere (at least in the PR body)
5 tasks
melekes
reviewed
Aug 29, 2018
server/tm_cmds.go
Outdated
| return cmd | ||
| } | ||
|
|
||
| func printCryptoWire(data interface{}) error { |
There was a problem hiding this comment.
I'd call it printlnJSON(v interface{}) error
ValarDragon
previously requested changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1274.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: