Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC and appmodulev2 handlers #21682

Closed
1 task done
julienrbrt opened this issue Sep 12, 2024 · 2 comments
Closed
1 task done

gRPC and appmodulev2 handlers #21682

julienrbrt opened this issue Sep 12, 2024 · 2 comments
Assignees
Labels
C:server/v2 Issues related to server/v2 T:Bug

Comments

@julienrbrt
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Handlers do not register grpc service.
Additionally, the grpc server doesn't create grpc service for handler either.

This first point gives a problem to AutoCLI which checks the interface registry for creating commands.
The second point gives issues to any customer requiring gRPC for queries.

We should somehow add support for gRPC for handlers (in runtime and/or grpc server).

Cosmos SDK Version

v2

How to reproduce?

Try to enable AutoCLI when using handlers instead of msg/query server: https://github.com/cosmos/cosmos-sdk/actions/runs/10813674735/job/29998285552

@julienrbrt
Copy link
Member Author

With the new gRPC v2 service, this is solved.
We should still check about AutoCLI in another issue

@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Nov 19, 2024
@julienrbrt
Copy link
Member Author

ref: #22333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2 T:Bug
Projects
Status: 🥳 Done
Development

No branches or pull requests

3 participants