Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get consensus params in comet server #20996

Closed
julienrbrt opened this issue Jul 19, 2024 · 1 comment · Fixed by #21248
Closed

Get consensus params in comet server #20996

julienrbrt opened this issue Jul 19, 2024 · 1 comment · Fixed by #21248
Assignees
@tac0turtle
Labels
C:server/v2 Issues related to server/v2

Comments

@julienrbrt
Copy link
Member

We should get the consensus params in CometBFT ABCI Info call.

Currently, simply trying to get them gives this at server start:

failed to start servers: error during handshake: error calling Info: rpc error: code = Internal desc = collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/cometbft.types.v1.ConsensusParams

ref #20989 (comment)
@julienrbrt julienrbrt added the C:server/v2 Issues related to server/v2 label Jul 19, 2024
@julienrbrt julienrbrt mentioned this issue Jul 19, 2024
Merged
12 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Jul 19, 2024
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jul 19, 2024
@julienrbrt julienrbrt self-assigned this Jul 23, 2024
@julienrbrt julienrbrt removed the needs-triage Issue that needs to be triaged label Jul 23, 2024
@julienrbrt julienrbrt removed their assignment Aug 3, 2024
@akhilkumarpilli akhilkumarpilli self-assigned this Aug 6, 2024
@akhilkumarpilli akhilkumarpilli moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Aug 6, 2024
@tac0turtle
Copy link
Member

solved in another pr of mine

@tac0turtle tac0turtle mentioned this issue Aug 12, 2024
Merged
12 tasks
@tac0turtle tac0turtle moved this from 🤸‍♂️ In Progress to 👀 Waiting / In review in Cosmos-SDK Aug 12, 2024
@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Aug 12, 2024
@mergify mergify bot mentioned this issue Aug 12, 2024
Merged
12 tasks
@tac0turtle tac0turtle removed this from Cosmos-SDK Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
C:server/v2 Issues related to server/v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove consensus messages cosmos/cosmos-sdk
3 participants
@tac0turtle @julienrbrt @akhilkumarpilli