Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/sims support for runtime/v2 #20469

Closed
Tracked by #20439
kocubinski opened this issue May 28, 2024 · 3 comments · Fixed by #23013
Closed
Tracked by #20439

tests/sims support for runtime/v2 #20469

kocubinski opened this issue May 28, 2024 · 3 comments · Fixed by #23013
Assignees
Labels
C:server/v2 Issues related to server/v2

Comments

@kocubinski
Copy link
Member

kocubinski commented May 28, 2024

simulation.SimulateFromSeed expects a BaseApp. Is it possible for this function to accept an abstraction which both BaseApp and something from runtime/v2 satisfy?

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 28, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK May 28, 2024
@tac0turtle tac0turtle added C:server/v2 Issues related to server/v2 and removed needs-triage Issue that needs to be triaged labels May 28, 2024
@coderabbitai coderabbitai bot mentioned this issue May 31, 2024
12 tasks
@alpe
Copy link
Contributor

alpe commented Jul 15, 2024

The dependency to *Baseapp could be dropped by an interface that supports methods for setup and flow control. The weighted/ future ops that are executed agains *Baseapp could be executed agains the following interface:

// AppEntrypoint defines the method for delivering simulation TX to the app. This is implemented by *Baseapp
type AppEntrypoint interface {
	SimDeliver(_txEncoder sdk.TxEncoder, tx sdk.Tx) (sdk.GasInfo, *sdk.Result, error)
}

This would be a breaking change though. My work in sims2 branch prepares for this already although I did not modify the Ops for compatibilty.

@julienrbrt
Copy link
Member

Currently blocked on #21907

@julienrbrt julienrbrt moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Nov 19, 2024
@julienrbrt julienrbrt moved this from 🥳 Done to ❌ Blocked in Cosmos-SDK Nov 19, 2024
@julienrbrt julienrbrt moved this from ❌ Blocked to 👀 Waiting / In review in Cosmos-SDK Dec 3, 2024
@tac0turtle
Copy link
Member

unblocked now woooo!!

@julienrbrt julienrbrt moved this from 👀 Waiting / In review to 🤸‍♂️ In Progress in Cosmos-SDK Dec 4, 2024
@julienrbrt julienrbrt moved this from 🤸‍♂️ In Progress to 👀 Waiting / In review in Cosmos-SDK Jan 7, 2025
@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:server/v2 Issues related to server/v2
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

4 participants