Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Amino JSON representation changed between cosmos-sdk 0.47 and 0.50 #19785

Closed
1 task done
pinosu opened this issue Mar 19, 2024 · 0 comments · Fixed by #19786
Closed
1 task done

[Bug]: Amino JSON representation changed between cosmos-sdk 0.47 and 0.50 #19785

pinosu opened this issue Mar 19, 2024 · 0 comments · Fixed by #19786
Labels

Comments

@pinosu
Copy link
Contributor

pinosu commented Mar 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

we have a big blocker issue for Cosmos SDK 0.50 adoption with wasmd: with the upgrade Cosmos SDK the Amino JSON representation of certain things changed in a breaking way. This was observed for some Cosmos SDK message types and we now have it for wasmd types as well. In both cases we have signer breaking changes due to custom MarshalJSON implementations of custom Go types.
In case of wasmd there is e.g.

  // Msg json encoded message to be passed to the contract on migration
  bytes msg = 5 [ (gogoproto.casttype) = "RawContractMessage" ];

where RawContractMessage is marshalled as a JSON document instead of base64 in the Amino JSON sign doc. This is not respected anymore with SDK 0.50. In this gist there is expected and actual sign doc compared (see msg field).

Cosmos SDK Version

0.50

How to reproduce?

No response

@pinosu pinosu added the T:Bug label Mar 19, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Mar 19, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Mar 27, 2024
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant