Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textual and Voting Options #19228

Closed
julienrbrt opened this issue Jan 24, 2024 · 2 comments · Fixed by #19718
Closed

Textual and Voting Options #19228

julienrbrt opened this issue Jan 24, 2024 · 2 comments · Fixed by #19718

Comments

@julienrbrt
Copy link
Member

When introducing multiple choice proposal, we've aliased the voting options to keep backward compatibility: https://github.com/cosmos/cosmos-sdk/blob/41c84d6/proto/cosmos/gov/v1/gov.proto#L30-L54
The choice has been made to have the options: option 1, 2, 3,.. as default while the previous options: yes, no, abstain, ... as alias.

These option can be used interchangeably in sign mode direct, which is perfect for the use case of multiple choice proposal, however in sign mode textual it does not work.

It has been investigated to create a custom message render option (#18849 (comment)) for gov voting, however at voting we do not know the proposal type for make the choice.
The quick solution is to inverse the alias, leaving yes, no, abstain as default and option 1, 2, 3 as the alias.
The drawback is that voting for a multiple choice proposal using textual will be weird (it will display vote yes, no, abstain) while you are actually voting on an option.

@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Jan 24, 2024
@facundomedica facundomedica changed the title Texual and Voting Options Textual and Voting Options Jan 25, 2024
@github-project-automation github-project-automation bot moved this from 👀 To Do to 🥳 Done in Cosmos-SDK Mar 12, 2024
@julienrbrt julienrbrt reopened this Mar 12, 2024
@github-project-automation github-project-automation bot moved this from 🥳 Done to 👀 To Do in Cosmos-SDK Mar 12, 2024
@julienrbrt
Copy link
Member Author

The workaround has been implemented in #19718, but this should still be investigated for a better UX.

@julienrbrt
Copy link
Member Author

Closing as won't fix (ref: #18591)

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

Successfully merging a pull request may close this issue.

1 participant