Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let confix migrate client.toml as well #18435

Closed
julienrbrt opened this issue Nov 10, 2023 · 3 comments · Fixed by #18455
Closed

Let confix migrate client.toml as well #18435

julienrbrt opened this issue Nov 10, 2023 · 3 comments · Fixed by #18455
Labels

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Nov 10, 2023

Like we are extending app.toml with other options, it happens that we are as well extending the client.toml.

For a better user experience, we should allow confix to create the new fields when upgrading SDK version. Confix only supports migrating an app.toml as of now.

Tasks


          I am going to leave this feature for v0.51 and improve confix to migrate client.toml as well for a better experience.

Originally posted by @julienrbrt in #18101 (comment)

@amedumer
Copy link
Contributor

Hey @julienrbrt , hope you are doing well. I did some work on the change you requested. I'm sure there will be things to change. Can you have a look when you have time? Thanks!

@julienrbrt
Copy link
Member Author

Hey @julienrbrt , hope you are doing well. I did some work on the change you requested. I'm sure there will be things to change. Can you have a look when you have time? Thanks!

Sure I'll have a look later. Thank you for taking this issue!

Once easy way to test is to try migrating a v0.50 client.toml to latest main (v0.51).

@amedumer
Copy link
Contributor

Once easy way to test is to try migrating a v0.50 client.toml to latest main (v0.51).

I tested this and it successfully added the gas-adjustment and keyring-default-keyname fields. That's what we are looking for right?

@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Nov 17, 2023
@tac0turtle tac0turtle moved this from 👀 To Do to 📚 In review in Cosmos-SDK Nov 17, 2023
@github-project-automation github-project-automation bot moved this from 📚 In review to 🥳 Done in Cosmos-SDK Nov 29, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants