Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improve getSDKVersion() to handle module replacements #17122

Closed
Ryz0nd opened this issue Jul 24, 2023 · 0 comments · Fixed by #17096
Closed

[Feature]: Improve getSDKVersion() to handle module replacements #17122

Ryz0nd opened this issue Jul 24, 2023 · 0 comments · Fixed by #17096

Comments

@Ryz0nd
Copy link
Contributor

Ryz0nd commented Jul 24, 2023

Summary

The getSDKVersion function in the current implementation returns the version of the original cosmos-sdk even when a replaced cosmos-sdk is being used. This causes an issue, especially in cases like Osmosis, where they utilize their own fork of the cosmos-sdk. The function should correctly identify and return the version of the replaced cosmos-sdk, but it currently returns the version of the original one.

Problem Definition

Osmosis go.mod

 require (
   github.com/cosmos/cosmos-sdk v0.47.3
 )
 
 replace (
   github.com/cosmos/cosmos-sdk => github.com/osmosis-labs/cosmos-sdk v0.45.0-rc1.0.20230703010110-ed4eb883f2a6
 )

Osmosis query - /cosmos/base/tendermint/v1beta1/node_info

{
  ...
  "application_version": {
   ...
   "cosmos_sdk_version": "v0.47.3" // to-be => v0.45.0-rc1.0.20230703010110-ed4eb883f2a6
  }
}

Proposal

#17096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant