Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckTx flow does not check if the handler exists for a given message #16610

Closed
angbrav opened this issue Jun 19, 2023 · 0 comments · Fixed by #16613
Closed

CheckTx flow does not check if the handler exists for a given message #16610

angbrav opened this issue Jun 19, 2023 · 0 comments · Fixed by #16613
Labels
needs-triage Issue that needs to be triaged

Comments

@angbrav
Copy link
Contributor

angbrav commented Jun 19, 2023

Description

CheckTx allows the addition of transactions consisting of messages with no handlers to the mempool. This follows from the fact that in RunTx() the check is only done if the mode is either execModeFinalize or execModeSimulate. This isn't serious but it's unnecessarily wasteful.

Version

Latest
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jun 19, 2023
@alexanderbez alexanderbez mentioned this issue Jun 19, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Issue that needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Ensure Handler Exists for Messages cosmos/cosmos-sdk
1 participant
@angbrav