Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: Refactor test_helper files into internal packages #1661

Closed
ValarDragon opened this issue Jul 12, 2018 · 2 comments
Closed

proposal: Refactor test_helper files into internal packages #1661

ValarDragon opened this issue Jul 12, 2018 · 2 comments
Labels
S:proposed T:Docs Changes and features related to documentation.

Comments

@ValarDragon
Copy link
Contributor

We don't want test_helper stuff showing up in the godocs, which should serve as our primary documentation for the API. We should refactor where applicable test helper code into internal packages. Reference for internal packages: https://golang.org/doc/go1.4#internalpackages
@ValarDragon ValarDragon added T:Docs Changes and features related to documentation. pre1.0 S:proposed labels Jul 12, 2018
@jackzampolin
Copy link
Member

cc @fedekunze

Removing 1.0 label as this isn't blocking.

@fedekunze
Copy link
Collaborator

There are multiple issues that address this too. I'd close it and move it to #4875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S:proposed T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ValarDragon @jackzampolin @fedekunze