Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of GetSignBytes #16024

Closed
kocubinski opened this issue May 3, 2023 · 0 comments · Fixed by #16048
Closed

Remove usages of GetSignBytes #16024

kocubinski opened this issue May 3, 2023 · 0 comments · Fixed by #16048
Assignees
@kocubinski

Comments

@kocubinski
Copy link
Member

Summary

Remove all usages of LegacyMsg.GetSignBytes.

This builds on work from #15698 which was the main use case for GetSignBytes. Remaining usages include client.AuxTxBuilder and simulations. Once these are removed we delete can delete message implementations of GetSignBytes and remove many init and global legacy amino codec usages. Removing this tech debt will resolve even more cyclic module dependencies furthering #11899.
@kocubinski kocubinski self-assigned this May 3, 2023
@kocubinski kocubinski mentioned this issue May 3, 2023
Merged
19 tasks
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK May 4, 2023
This was referenced May 4, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK May 8, 2023
@kocubinski kocubinski mentioned this issue May 16, 2023
Merged
19 tasks
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kocubinski kocubinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(x/tx): use dynamicpb instead of type resolver in any marshal cosmos/cosmos-sdk
1 participant
@kocubinski