Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manager methods should return errors instead of panicking #14836

Closed
Tracked by #14683
facundomedica opened this issue Jan 30, 2023 · 2 comments · Fixed by #14847
Closed
Tracked by #14683

Manager methods should return errors instead of panicking #14836

facundomedica opened this issue Jan 30, 2023 · 2 comments · Fixed by #14847
Assignees
@facundomedica

Comments

@facundomedica
Copy link
Member

No description provided.

@facundomedica facundomedica mentioned this issue Jan 30, 2023
Closed
14 tasks
@facundomedica facundomedica self-assigned this Jan 30, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jan 30, 2023
@facundomedica facundomedica moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jan 30, 2023
@alexanderbez
Copy link
Contributor

Which manager methods?

@facundomedica
Copy link
Member Author

@alexanderbez InitGenesis, ExportGenesis, BeginBlock and EndBlock. Only those right now

@facundomedica facundomedica mentioned this issue Jan 30, 2023
Merged
19 tasks
@github-project-automation github-project-automation bot moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jan 31, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundomedica facundomedica

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: return errors in module manager ABCI methods cosmos/cosmos-sdk
3 participants
@alexanderbez @facundomedica @tac0turtle