Keep increasing gas amount every time when unrevoke

[kwunyeung]

I have been revoked several time yesterday. I could unrevoke without the --gas flag before which means the default gas amount was enough to run the unrevoke. After a few unrevoke, I started to have to put the --gas flag and I have to increase it every time. Otherwise, the transaction will be out of gas. I originally put 300000 and it works, then it has to be 350000 to be through, then 400000.

[kwunyeung]

@cwgoes It eventually not only for unrevoke. Some other commands need more and more gas. I tried gaiacli stake unbond also reflecting this. Seems these affect those commands with stake module.

[cwgoes]

Thanks for reporting this. unrevoke should be more-or-less constant gas; it doesn't require iteration. Did you try attempting to replicate this on a local testnet? In either case, we'll look into it.

[kwunyeung]

@sherry13131 please see if we have similar situation in our testnet.

[cwgoes]

Alternatively, if you know the transaction hashes I can debug from those.

[cwgoes]

Thanks for reporting this. unrevoke should be more-or-less constant gas; it doesn't require iteration. Did you try attempting to replicate this on a local testnet? In either case, we'll look into it.

This isn't quite correct; in some cases unrevoke will cause iteration over validators, which will consume additional gas. Likely the number of validators just increased between your successive unrevoke calls. We plan to have the CLI simulate transactions and choose an appropriate gas amount automatically. Closing in favor of #1246 since this is expected behavior, but please reopen if you run into any abnormal gas increases on your testnet.