-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Circuit Breaker #14226
Comments
@aaronc how did you envision this working with checktx or the ante handler? |
Per offline discussions we agreed that AnteHandlers will be utilized in conjunction with the circuit breaker's logic. Feel free to add more detailed notes @aaronc. |
How about this interface: type CircuitBreaker interface {
IsBlocked(context.Context, sdk.Tx) bool
} with a new optional field |
LGTM 👍 |
closing this for now, we will make sure to include it in 0.50 and later backport to others |
Summary
Implement a small module which allows some authorized addresses to shut down module execution paths when security vulnerabilities are discovered.
Problem Definition
Circuit breakers have been discussed before #926 but never implemented. Essentially, we need a way to shut down critical exploit paths of security vulnerabilities ASAP before they can be exploited.
Proposal
I propose a very minimum viable circuit breaker module with the following features:
Msg
execution paths)Msg
execution paths in the ante handle, or even disable allMsg
sIn the future, we can iterate and add more advanced features, but what is proposed above can be implemented and released relatively quickly.
The text was updated successfully, but these errors were encountered: