Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deterministic test for ModuleAccountByName query #13704

Closed
Tracked by #13041
amaury1093 opened this issue Oct 31, 2022 · 0 comments · Fixed by #13715
Closed
Tracked by #13041

Add deterministic test for ModuleAccountByName query #13704

amaury1093 opened this issue Oct 31, 2022 · 0 comments · Fixed by #13715
Assignees
@atheeshp

Comments

@amaury1093
Copy link
Contributor

Summary

Add deterministic test for ModuleAccountByName query

Problem Definition

cosmos-sdk/proto/cosmos/auth/v1beta1/query.proto

Line 56 in a7a7d6d

rpc ModuleAccountByName(QueryModuleAccountByNameRequest) returns (QueryModuleAccountByNameResponse) {

This query was added recently, with the module_query_safe annotation, but no test was added.

Proposal

Add deterministic and regression test, like other queries
@amaury1093 amaury1093 moved this to 📝 Todo in Cosmos-SDK Oct 31, 2022
@amaury1093 amaury1093 mentioned this issue Oct 31, 2022
Closed
8 tasks
@atheeshp atheeshp self-assigned this Oct 31, 2022
@atheeshp atheeshp mentioned this issue Nov 1, 2022
Merged
19 tasks
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Nov 2, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add deterministic tests for ModuleAccountByName cosmos/cosmos-sdk
2 participants
@amaury1093 @atheeshp