Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contra 46 #13561

Closed
faddat opened this issue Oct 17, 2022 · 3 comments
Closed

Contra 46 #13561

faddat opened this issue Oct 17, 2022 · 3 comments

Comments

@faddat
Copy link
Contributor

faddat commented Oct 17, 2022

Hey, so,

Myself and Notional have been likely the largest users of the 46 series SDK.

Kudos to efforts from Umee, as well.

With that said--

I think that we should retract it.

Notional's efforts around Cosmos SDK v0.46.* are on pause due to dragonberry. While one side of my brain is screaming "hey, we gotta patch 46, and get going again" I try my best to stick to realism and pragmatism.

There aren't enough experienced engineers in cosmos to maintain all of the things well. 47 contains a number of clear improvements over 46, and will likely result in more maintainable, nimble chains for all. I'd like to recommend:

  • efforts at patching 46 be redirected towards building 47 and ensuring that 45 and 44 are very solidly patched

  • 47 be considered a "unity release" -- key libraries like:

    • ibc-go
    • cosmwasm
    • interchain-accounts-demo

Should be upgraded to 47.

Therefore I propose:

  • ecosystem efforts be directed towards ensuring that 44 and 45 are secured against dragons
  • Teams using 46 (Umee, Pylons, Quasar, okp4, eve, and a few others ) be assisted with migration away from 46 in a very active, hands-on manner to ensure that when 47 makes its final release, all support for 46 can be terminated
  • Concise migration documents be created containing best practices and guidelines for moving to 47 from 44, 45, 46.
  • Efforts to communicate the changes in 47 communicated on twitter, facebook, youtube, etc
  • Osmosis-sdk terminated in favor of 47
  • Termination of efforts to move Gaia to 46
  • Officially frowning upon SDK forks, and facilitating replaces / patches in the style of https://github.com/iqlusioninc/liqudity-staking-module / https://github.com/mars-protocol/hub

Notional and I ca help with a great deal of this work. Overall, we feel that it is best to secure what's widely deployed (44, 45) and then move to 47 while providing assistance to teams who've deployed 46 or are building on 46.

If you would like to join a chat group on this topic, please drop your twitter handle here and I'll spin that up.

to re-emphasize: I genuinely think it's best to walk away from 46

to re-emphasize: we should prioritize 44 and 45, then 47

to re-emphasize: Gaia should never make a release on 46

Key Github Issues relating to 47

Places I've posted this:

Teams we'll be reaching out to

  • okp4
  • umee
  • crypto.org
  • pylons
  • quasar
  • eve
  • ignite cli
  • gaia
  • ibc-go

Final restatement of position

Due to the clear superieority of building with 47 and the hard fact that maintaining 46 is an operational burden, I think it is best to scupple it in favor of a "unity release" (47) which is clearly better than 47.

Gaia should demonstrate leadership by adopting all major sdk versions henceforth. If she doesn't she shouldn't be treated as any kind of flagship for cosmos.

Notional Labs work to ensure that 46 was workable

@faddat
Copy link
Contributor Author

faddat commented Oct 17, 2022

This was aimed not at creating distraction, but instead, at reducing scope of work. Much of the driver here deals with cosmwasm.

If there are alternatives, love to hear about it.

Screen Shot 2022-10-17 at 1 49 59 PM

@faddat
Copy link
Contributor Author

faddat commented Oct 17, 2022

closed cause unhelpful.....

?

@faddat faddat closed this as completed Oct 17, 2022
@robert-zaremba
Copy link
Collaborator

Thanks for the write up @faddat

I don't think 0.46 should be retracted. It is continuous improvement over the past versions. Many new things in 0.46 are opt-in (x/nft, x/group, pulsar). Few bug fixes which are state breaking. IMHO, it was a great work. (BTW: i still see the future for the middlewares which were rolled back from 0.46).

People were complaining that 0.46 is too big. It is not a valid argument to retract it.

Others probably didn't clearly understand the changeset. Probably we need to make it more clear why 0.46 is IMPROVEMENT.

0.47 is another continuous improvement.

What we really need is MORE COORDINATION between CORE TEAMS to align with updates.
0.46 ecosystem upgrade was mainly driven by the contributions (Notional and us - Umee).

Looking forward for growing collaboration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants