Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation around deterministic queries #13464

Closed
Tracked by #13041
amaury1093 opened this issue Oct 6, 2022 · 0 comments · Fixed by #13613
Closed
Tracked by #13041

Add documentation around deterministic queries #13464

amaury1093 opened this issue Oct 6, 2022 · 0 comments · Fixed by #13613
Assignees
@atheeshp
Labels
T:Docs Changes and features related to documentation.

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Oct 6, 2022 •
edited
Loading

Summary

Add documentation around deterministic queries. Part of #13041

Problem Definition

We added the module_query_safe proto annotation. We should document them, because if not used correctly, they can lead to attack vectors.

Proposal

Document the set of guarantees that comes with a grpc query marked as module_query_safe:

  • responses are deterministic and not breaking across patch releases
  • gas is properly accounted for
@amaury1093 amaury1093 added the T:Docs Changes and features related to documentation. label Oct 6, 2022
@amaury1093 amaury1093 self-assigned this Oct 6, 2022
@amaury1093 amaury1093 mentioned this issue Oct 6, 2022
Closed
8 tasks
@amaury1093 amaury1093 moved this to 📝 Todo in Cosmos-SDK Oct 19, 2022
@amaury1093 amaury1093 assigned atheeshp and unassigned amaury1093 Oct 20, 2022
@amaury1093 amaury1093 moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Oct 20, 2022
@atheeshp atheeshp mentioned this issue Oct 21, 2022
Merged
19 tasks
@amaury1093 amaury1093 moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Oct 26, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Oct 26, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: deterministic query tests cosmos/cosmos-sdk
2 participants
@amaury1093 @atheeshp