Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ORM updates and deletes for simple tables #11561

Closed
aaronc opened this issue Apr 6, 2022 · 0 comments
Closed

Optimize ORM updates and deletes for simple tables #11561

aaronc opened this issue Apr 6, 2022 · 0 comments
Labels

Comments

@aaronc
Copy link
Member

aaronc commented Apr 6, 2022

In #11525, update and delete for bank balances is significantly slower with the ORM than a manual implementation because the ORM naively assumes that we always need to get and unmarshal the existing object to update and delete indexes. This is a safe general assumption, but we should add an optimization for cases where this isn't needed like bank balance and supply.

One complexity is making sure gas consumption is deterministic (already tracked in #11088). The ORM should have a well specified gas consumption model regardless of any read optimizations an implementation is able make.

@aaronc aaronc added the C:orm label Apr 6, 2022
@tac0turtle tac0turtle added this to the v0.47 milestone Apr 18, 2022
@tac0turtle tac0turtle removed this from the Next milestone May 12, 2022
@tac0turtle tac0turtle moved this to ❌ Blocked in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle moved this from ❌ Blocked to ☃️ Icebox in Cosmos-SDK Mar 13, 2024
@tac0turtle tac0turtle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@github-project-automation github-project-automation bot moved this from Ice Box to Done in Cosmos SDK: Framework WG Oct 1, 2024
@github-project-automation github-project-automation bot moved this from ☃️ Icebox to 🥳 Done in Cosmos-SDK Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🥳 Done
Development

No branches or pull requests

2 participants