Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx result report block gas used as tx gas used #10832

Closed
4 tasks
yihuang opened this issue Dec 23, 2021 · 2 comments
Closed
4 tasks

tx result report block gas used as tx gas used #10832

yihuang opened this issue Dec 23, 2021 · 2 comments
Labels
T:Bug

Comments

@yihuang
Copy link
Collaborator

yihuang commented Dec 23, 2021

Summary of Bug

https://github.com/cosmos/cosmos-sdk/blob/release/v0.44.x/baseapp/baseapp.go#L586

when block gas limit exceeded, the tx result report block gas used as tx gas used.

Version

v0.45.x/v0.44.x/v0.43.x/v0.42.x

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@yihuang yihuang mentioned this issue Dec 23, 2021
Merged
19 tasks
yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Jan 3, 2022
@yihuang
tx result report block gas used as tx gas used
ec3cf6b 
Closes: cosmos#10832
Solution: Return empty GasInfo.
@fedekunze fedekunze added the T:Bug label Jan 5, 2022
@fedekunze
Copy link
Collaborator

would be great to include it in v0.45

amaury1093 added a commit that referenced this issue Jan 5, 2022
@yihuang @amaury1093
fix!: tx result don't report block gas used as tx gas used (#10833)
6d44d71 
* tx result report block gas used as tx gas used

Closes: #10832
Solution: Return empty GasInfo.

* Update CHANGELOG.md

Co-authored-by: Amaury <[email protected]>
@yihuang
Copy link
Collaborator Author

yihuang commented Jan 18, 2022

fixed by: #10833

@yihuang yihuang closed this as completed Jan 18, 2022
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this issue Jul 7, 2022
@yihuang @amaury1093 @JimLarson
fix!: tx result don't report block gas used as tx gas used (cosmos#10833
1aa8c20 
)

* tx result report block gas used as tx gas used

Closes: cosmos#10832
Solution: Return empty GasInfo.

* Update CHANGELOG.md

Co-authored-by: Amaury <[email protected]>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this issue Sep 28, 2024
@yihuang @amaury1093 @JeancarloBarrios
fix!: tx result don't report block gas used as tx gas used (cosmos#10833
a4fe669 
)

* tx result report block gas used as tx gas used

Closes: cosmos#10832
Solution: Return empty GasInfo.

* Update CHANGELOG.md

Co-authored-by: Amaury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yihuang @fedekunze