Move community pool into its own module

[ValarDragon]

Summary

Currently the community pool is wrtitten in the Distribution module. However, a module wanting to send coins to the community pool is a pretty common feature. This causes lots of awkward dependencies for modules on the distribution module, which really should just be handling token distribution between modules.

Proposal

I suggest that we split out the community pool into its own, quite small module. This module can even be our reference for how simple a module that just handles a module account is.

I also suggest we make type alias' / re-exports of methods in Distribution of the community pool modules methods, so as to not break existing code.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[tac0turtle]

Huge fan of this!! I always found it weird it was combined.

[alexanderbez]

What would actually be in this module? I guess just the community spend proposal handler? There isn't any state machine logic unique to it. The main dep is the module name of distribution. Not opposed to the idea, but i'm just curious

[ValarDragon]

community spend proposal handler, fund community pool message & keeper methods.

Really not much!

[alexanderbez]

Which keeper methods?

[ValarDragon]

only seem seems to be Fund Community Pool

[alexanderbez]

Ok, why not. ACK 👍

[ValarDragon]

Another reason to do this: Currently there is no module account just for the community pool. There is a module account for distribution, which contains both unclaimed commissions, and the community pool assets.

It'll give a better user-flow if folks can monitor the community pool on block explorers just like every other address. (e.g. in Osmosis, the distribution address has 46M osmo https://www.mintscan.io/osmosis/account/osmo1jv65s3grqf6v6jl3dp4t6c9t9rk99cd80yhvld, but the community pool only has 40M. Theres 6M in unclaimed commissions)

Thanks to @czarcas7ic for pointing this out

[alexanderbez]

Agreed.

[aaronc]

We should probably sync discussion this with the ongoing gov refactor. /cc @cmwaters

[cmwaters]

Another idea that was brought up in the governance working group was to have the community pool just be the gov module account that way a community pool spend is just the gov account sending tokens to another account or module

[aaronc]

I do question whether the community pool actually needs much more than a gov controlled address as @cmwaters is suggesting. Is there any need to protect it with invariants for instance? I'm not sure there's a good reason people shouldn't be able to send arbitrary coins to it.

[ValarDragon]

People should imo be able to send arbitrary coins to it. I believe the current FundCommunityPool message only exists because the community pool is managed as a subset of the distribution module account atm

[tac0turtle]

this ties into the work that @testinginprod is doing on accounts v2