fix: query account balance by ibc denom

[gsk967]

Description

Closes: #10381

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[robert-zaremba]

@gsk967 - what's the ETA? We are ready to release next patch release for 0.42 and 0.44. Would be great to have this included as well.

[gsk967]

@robert-zaremba
I tried the {denom=**} it is working but this change breaking the account balance route

unescaping setting for grpc-gateway runtime is added in latest grpc-gateway
https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_your_gateway/#controlling-path-parameter-unescaping

May be we can move denom params from route path to route query

if req.denom == "" || req.denom == nil  
  GetAccountBalance
else
  GetAccountBalanceByDenom 

[robert-zaremba]

We can, but this is breaking.
Do you have an idea if fixing it without breaking an API?

[gsk967]

No @robert-zaremba

[alexanderbez]

so this is a gRPC issue? I was hoping we could just update the handler to URI decode the denom.

[robert-zaremba]

would it be possible to somehow manually resolve it? Or using:

...?denom={denom....}   // not sure what should go here

[gsk967]

We will make one route for query AllBalances and Balance together

denom and pagination both are optional params for route

if req.denom == "" || req.denom == nil  
  GetAccountBalance
else
  GetAccountBalanceByDenom 

// AllBalances queries the balance of all coins for a single account.
  rpc AccountBalance(QueryAccountBalance) returns (QueryAccountBalanceResponse) {
    option (google.api.http).get = "/cosmos/bank/v1beta1/balances/{address}";
  }

// QueryBalanceRequest is the request type for the Query/Balance RPC method.
message QueryAccountBalance {
  option (gogoproto.equal)           = false;
  option (gogoproto.goproto_getters) = false;

  // address is the address to query balances for.
  string address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];

  // denom is the coin denom to query balances for.
  string denom = 2;

 // pagination defines an optional pagination for the request.
  cosmos.base.query.v1beta1.PageRequest pagination = 3;
}


// QueryBalanceResponse is the response type for the Query/Balance RPC method.
message QueryAccountBalanceResponse {
  // balance is the balance of the coin.
  cosmos.base.v1beta1.Coin balance = 1;

// balances is the balances of all the coins.
  repeated cosmos.base.v1beta1.Coin balances = 2
      [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"];

  // pagination defines the pagination in the response.
  cosmos.base.query.v1beta1.PageResponse pagination = 3;
}

[gsk967]

@robert-zaremba ^^^

[gsk967]

@robert-zaremba i think we can't do backport this because it is breaking proto change
so i changed to grpc-gateway to fix the ibc-denom issue

 rpc Balance(QueryBalanceRequest) returns (QueryBalanceResponse) {
    option (google.api.http).get = "/cosmos/bank/v1beta1/balances/{address}/by_denom";
  }

Now denom is query params to this route

{API}/cosmos/bank/v1beta1/balances/{address}/by_denom?denom={DENOM or IBC-DENOM}

[alexanderbez]

@robert-zaremba or @AmauryM, i'm not super familiar with the current gRPC logic. Do these proposals sound reasonable?

[anilcse]

This approach sounds reasonable to me

[codecov]

Codecov Report

Merging #10394 (ae93ce9) into master (2394266) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head ae93ce9 differs from pull request most recent head d60f2e9. Consider uploading reports for the commit d60f2e9 to get more accurate results

@@            Coverage Diff             @@
##           master   #10394      +/-   ##
==========================================
+ Coverage   64.33%   64.42%   +0.09%     
==========================================
  Files         592      573      -19     
  Lines       56008    54619    -1389     
==========================================
- Hits        36034    35191     -843     
+ Misses      17912    17431     -481     
+ Partials     2062     1997      -65     

Impacted Files	Coverage Δ
x/bank/client/testutil/grpc.go	100.00% <100.00%> (ø)
x/mint/module.go	52.54% <0.00%> (-3.02%)	⬇️
x/auth/tx/builder.go	76.05% <0.00%> (-2.55%)	⬇️
store/cachekv/store.go	77.63% <0.00%> (-1.32%)	⬇️
store/cachemulti/store.go	9.52% <0.00%> (-0.48%)	⬇️
crypto/keyring/legacy_info.go	61.95% <0.00%> (-0.41%)	⬇️
crypto/keyring/keyring.go	61.98% <0.00%> (-0.03%)	⬇️
server/init.go	55.55% <0.00%> (ø)
baseapp/baseapp.go	67.11% <0.00%> (ø)
client/keys/rename.go	69.76% <0.00%> (ø)
... and 37 more

[anilcse]

utACK