cosmos-sdk-protos: add grpc-transport feature
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #226 Adds an on-by-default `grpc-transport` feature which enables the corresponding `transport` feature in `tonic`. To make this work with generated code, the generated protos are patched to feature-gate the `tonic::transport`-dependent code.
tony-iqlusion
commented
May 16, 2022
proto-build/src/main.rs
Outdated
Comment on lines
437
to
451
| let patched_contents = | ||
| contents.replace(TONIC_CLIENT_ATTRIBUTE, &GRPC_CLIENT_ATTRIBUTES.join("\n")); | ||
| let contents = contents.replace(TONIC_CLIENT_ATTRIBUTE, &GRPC_CLIENT_ATTRIBUTES.join("\n")); | ||
|
|
||
| fs::write(dest, patched_contents) | ||
| // Feature gate gRPC client impl blocks which rely on `tonic::transport` | ||
| let contents = Regex::new(TONIC_CLIENT_IMPL) | ||
| .unwrap() | ||
| .replace_all(&contents, TONIC_CLIENT_REPLACEMENT); | ||
|
|
||
| // Write output to destination | ||
| fs::write(dest, &*contents) |
There was a problem hiding this comment.
It might be worth refactoring how these transformations are applied to the generated protos, making it into an folding iterator over Regex and replacement string tuples that applies successive transformations
|
Went ahead and did the cleanup I proposed regarding the regex substitutions on the output |
tony-iqlusion
force-pushed
the
cargo-sdk-proto/grpc-transport-feature
branch
from
a9ca34f to
7a3d5f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226
Adds an on-by-default
grpc-transportfeature which enables the correspondingtransportfeature intonic. The main use case is supporting gRPC in WASM environments.To make this work with generated code, the generated protos are patched to feature-gate the
tonic::transport-dependent code.