cosmrs v0.3.0 #150
Merged
cosmrs v0.3.0 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
commented
Oct 28, 2021
| //! # Cosmos SDK for Rust | ||
| //! | ||
| //! Framework for building [Cosmos] blockchain applications in Rust, modeled off | ||
| //! of the [Cosmos SDK for Golang]. | ||
| //! | ||
| //! ## About | ||
| //! | ||
| //! This library is presently designed to serve as a *client* for interacting | ||
| //! with the Golang implementation of the Cosmos SDK. | ||
| //! | ||
| //! It does not implement server-side functionality (yet), such as hooks | ||
| //! and message passing. | ||
| //! | ||
| //! ## Features | ||
| //! | ||
| //! - [CosmWasm][`cosmwasm`]: messages used by smart contracts written using CosmWasm | ||
| //! - [Staking][`staking`]: support for staking with validators | ||
| //! - [Transactions][`tx`]: build, sign, and/or parse Cosmos SDK transactions | ||
| //! | ||
| //! [Cosmos]: https://cosmos.network/ | ||
| //! [Cosmos SDK for Golang]: https://github.com/cosmos/cosmos-sdk | ||
|
|
||
| #![cfg_attr(docsrs, feature(doc_cfg))] | ||
| #![doc = include_str!("../README.md")] |
There was a problem hiding this comment.
Note: gave this crate the include_str! treatment as well. Here's a rendered screenshot of the docs:
andynog
approved these changes
Oct 29, 2021
| @@ -1,4 +1,4 @@ | |||
| # CosmRS: Cosmos SDK for Rust | |||
| # CosmRS: Cosmos Wallet and SDK for Rust | |||
There was a problem hiding this comment.
Should we say it's a wallet ? Are there functionalities to build wallets yet in the library other than account ?
Thinking that this might still need some Wallet constructs that take mnemonics etc to build the wallets no ? Something like https://github.com/forbole/cosmos-rust-wallet/tree/main/packages/crw-wallet
There was a problem hiding this comment.
CosmRS has had BIP32 support for awhile now. It's perhaps a bit underdocumented.
From the 0.1.0 release:
https://docs.rs/cosmrs/0.1.0/cosmrs/crypto/secp256k1/struct.SigningKey.html#method.derive_from_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Prototype toMsgtrait - formerly namedMsgType(#146)from_any/to_anymethods toMsgtrait - formerly namedMsgType(#146)/cosmos.crypto.multisig.LegacyAminoPubKeysupport (#147)SignerPublicKeyenum forSignerInfo::public_key(#147)Changed
tx::MsgTypetrait totx::Msg(#146)MsgProto::from_msg/to_msgtofrom_any/to_any(#146)cosmos-sdk-prototo v0.8 (#149)Removed
tx::Msgnewtype forprost_types::Any. UseAnyinstead (#146)