Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ProtoReflect return the message #6

Closed
aaronc opened this issue Jul 14, 2021 · 0 comments · Fixed by #9
Closed

Make ProtoReflect return the message #6

aaronc opened this issue Jul 14, 2021 · 0 comments · Fixed by #9

Comments

@aaronc
Copy link
Member

aaronc commented Jul 14, 2021

Currently ProtoReflect() returns the reflection based protoreflect.Message, but since we are implemented protoreflect.Message on our message type directly (for now), we need to change this to:

func (x *Bar) ProtoReflect() protoreflect.Message {
	return x
}

This also means that all the generated methods like Descriptor can't just call ProtoReflect().Descriptor() because that would be self reflexive. But we can deal with that in #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make ProtoReflect() return the message cosmos/cosmos-proto
1 participant
@aaronc