Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_IBC doesn't follow naming conventions of all other JSON files #632

Closed
pyramation opened this issue Aug 18, 2022 · 1 comment · Fixed by #681
Closed

_IBC doesn't follow naming conventions of all other JSON files #632

pyramation opened this issue Aug 18, 2022 · 1 comment · Fixed by #681
Assignees
@JeremyParish69

Comments

@pyramation
Copy link
Collaborator

everything uses underscore_casing and _IBC uses the least-used JSON notation style with dashed-case which is very hard to work with in JS and JSON in general due to escaping.

Can we use convention and stick to underscore?

e.g. chain-1 => chain1 and channel-id => channel_id?
@sunnya97
Copy link
Member

This makes sense. I think we should fix this

@JeremyParish69 JeremyParish69 mentioned this issue Aug 31, 2022
Merged
@pyramation pyramation mentioned this issue Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeremyParish69 JeremyParish69

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IBC files::Replace dashes with underscores JeremyParish69/chain-registry
3 participants
@pyramation @sunnya97 @JeremyParish69