Downloaded the wrong favicon?

[hojjatabdollahi]

I know you're actively working on the new features, but I thought maybe I report this:

I'm on the latest commit: eaff02c.
I'm trying to add a Google Messages shortcut, but the icon that "Download favicon" downloads is not the same shown in the app.

It does correctly download Github, Proxmox, Youtube favicons, but it fails with Google Messages, or Google Maps.

I downloaded the icon and opened it in the icon selector, it changed in the UI. I pressed done, but nothing happened. The old icon stayed.

[hepp3n]

I know you're actively working on the new features, but I thought maybe I report this:

Hello and thanks! The reason I pushed it to master was idea to get some feedback before pushing to flathub :D

I will try to reproduce it and see what's the problem. Imho it should download correct favicon but the problem is with prioritization of favicon instead of local Papirus icons (or installed icons packs).

[hepp3n]

Ok, so there are 2 issues.

First one. We were looking for images in sizes 64x64px.
The favicon provided by our service is this:
https://lh3.googleusercontent.com/_H5q5XeaJ494rnsUwSCX6FCg4myBzqijlXev3IHby8QEI9L4Rza_wU31AsW18mEI_gWa5fh0bO-FOPcq6JU3Mpk4Jdmp-UxjQCIa1oI=e365-w64-rp
even if it looking for domain: messages.google.com

I'm not sure about solution. I'm happy with the results from faviconextractor.com/api so I would not change this provider. My recommendations would be to use some of the icons from Papirus pack, there are few related. It will works.

I downloaded the icon and opened it in the icon selector, it changed in the UI. I pressed done, but nothing happened. The old icon stayed.

I found this bug before. The icon should be updated after re-open application (Quick Web Apps). If you could test this case would be nice. I will fix it of course.

[hepp3n]

My solution for now is to reduce size for icons to 42px (so lower resolution images will qualify). You will get this result after it: https://lh3.googleusercontent.com/_H5q5XeaJ494rnsUwSCX6FCg4myBzqijlXev3IHby8QEI9L4Rza_wU31AsW18mEI_gWa5fh0bO-FOPcq6JU3Mpk4Jdmp-UxjQCIa1oI=e365-w64-rp

The problem with favicons is, they are mostly low quality, low sizes images, since it's only favicons. FaviconExtractor gives us some higher quality icons.