Skip to content

Commit

Permalink
Backport Hermes release fix on main (facebook#37685)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#37685

I'm backporting this comming `60a452b4853dc5651c465867344904dd6fc86703`
from the release branch of 0.72-stable to main which fixes this issue
in the Android NDK:
android/ndk#1740 (comment)

Changelog:
[Internal] [Changed] - Backport Hermes release fix on `main`

Reviewed By: mdvacca

Differential Revision: D46398346

fbshipit-source-id: 7071c3324ade74cbad9b5646af2442f0e462cfeb
  • Loading branch information
cortinico authored and facebook-github-bot committed Jun 5, 2023
1 parent 2d07d5f commit 5d5eb0e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/react-native/ReactAndroid/hermes-engine/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ android {
// This has the (unlucky) side effect of letting AGP call the build
// tasks `configureCMakeRelease` while is actually building the debug flavor.
arguments "-DCMAKE_BUILD_TYPE=Release"
// Adding -O3 to handle the issue here: https://github.com/android/ndk/issues/1740#issuecomment-1198438260
// The old NDK toolchain is not passing -O3 correctly for release CMake builds. This is fixed in NDK 25 and can be removed once we're there.
cppFlags "-O3"
}
}
}
Expand Down

0 comments on commit 5d5eb0e

Please sign in to comment.