From 14f801da2d5b5d53508964588165699685c037e6 Mon Sep 17 00:00:00 2001 From: Misha Brukman Date: Fri, 28 Jul 2017 15:38:45 -0400 Subject: [PATCH] Fix capitalization of "Bigtable". --- pkg/chunk/gcp/instrumentation.go | 4 ++-- pkg/chunk/gcp/storage_client.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/chunk/gcp/instrumentation.go b/pkg/chunk/gcp/instrumentation.go index 3211f0ef9f..81d978c856 100644 --- a/pkg/chunk/gcp/instrumentation.go +++ b/pkg/chunk/gcp/instrumentation.go @@ -17,9 +17,9 @@ import ( var bigtableRequestDuration = prometheus.NewHistogramVec(prometheus.HistogramOpts{ Namespace: "cortex", Name: "bigtable_request_duration_seconds", - Help: "Time spent doing BigTable requests.", + Help: "Time spent doing Bigtable requests.", - // BigTable latency seems to range from a few ms to a few sec and is + // Bigtable latency seems to range from a few ms to a few sec and is // important. So use 8 buckets from 128us to 2s. Buckets: prometheus.ExponentialBuckets(0.000128, 4, 8), }, []string{"operation", "status_code"}) diff --git a/pkg/chunk/gcp/storage_client.go b/pkg/chunk/gcp/storage_client.go index feaea9aafe..4c406ec26b 100644 --- a/pkg/chunk/gcp/storage_client.go +++ b/pkg/chunk/gcp/storage_client.go @@ -24,8 +24,8 @@ type Config struct { // RegisterFlags adds the flags required to config this to the given FlagSet func (cfg *Config) RegisterFlags(f *flag.FlagSet) { - f.StringVar(&cfg.project, "bigtable.project", "", "BigTable project ID.") - f.StringVar(&cfg.instance, "bigtable.instance", "", "BigTable instance ID.") + f.StringVar(&cfg.project, "bigtable.project", "", "Bigtable project ID.") + f.StringVar(&cfg.instance, "bigtable.instance", "", "Bigtable instance ID.") } // storageClient implements chunk.storageClient for GCP. @@ -116,7 +116,7 @@ func (s *storageClient) QueryPages(ctx context.Context, query chunk.IndexQuery, } return table.ReadRows(ctx, rowRange, func(r bigtable.Row) bool { - // BigTable doesn't know when to stop, as we're reading "until the end of the + // Bigtable doesn't know when to stop, as we're reading "until the end of the // row" in DynamoDB. So we need to check the prefix of the row is still correct. if !strings.HasPrefix(r.Key(), query.HashValue+separator) { return false @@ -125,7 +125,7 @@ func (s *storageClient) QueryPages(ctx context.Context, query chunk.IndexQuery, }, bigtable.RowFilter(bigtable.FamilyFilter(columnFamily))) } -// bigtableReadBatch represents a batch of rows read from BigTable. As the +// bigtableReadBatch represents a batch of rows read from Bigtable. As the // bigtable interface gives us rows one-by-one, a batch always only contains // a single row. type bigtableReadBatch bigtable.Row