Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some screenshot JSON issues #2454

Merged
merged 4 commits into from
Jun 1, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data/screenshots-archive-2-6.json
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
},
{
"title": "Check certificates for validity before a trip",
"anchor": "ios_check_validity_certificate",
"anchor": "android_check_validity_certificate",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably this is not much better because the screenshots below are actually for iOS; however this is the Android section.
Maybe this section should be removed completely for Android then, in case no screenshots exist for it?

"images": [
{ "filename": "/assets/screenshots/2-6/en/ios/iPhone 11 Pro-screenshot_first_vaccination_certificate_details_part1", "alt": "Certificate check image 1 of 4" },
{ "filename": "/assets/screenshots/2-6/en/ios/iPhone 11 Pro-screenshot_certificate_validation_date_selection", "alt": "Certificate check image 2 of 4" },
Expand Down
2 changes: 1 addition & 1 deletion src/data/screenshots-archive-2-6_de.json
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
},
{
"title": "Zertifikate vor einer Reise auf Gültigkeit prüfen",
"anchor": "ios_check_validity_certificate",
"anchor": "android_check_validity_certificate",
Copy link
Contributor Author

@Marcono1234 Marcono1234 Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"images": [
{ "filename": "/assets/screenshots/2-6/de/ios/iPhone 11 Pro-screenshot_first_vaccination_certificate_details_part1", "alt": "Zertifikate auf Gültigkeit prüfen Bild 1 von 4" },
{ "filename": "/assets/screenshots/2-6/de/ios/iPhone 11 Pro-screenshot_certificate_validation_date_selection", "alt": "Zertifikate auf Gültigkeit prüfen Bild 2 von 4" },
Expand Down
2 changes: 1 addition & 1 deletion src/data/screenshots-archive-2-7_de.json
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
},
{
"title": "Testzertifikat",
"anchor": "android_vaccination_certificate",
"anchor": "android_test_certificate",
"images": [
{ "filename": "/assets/screenshots/2-7/de/android/HomeFragment_low_risk_no_encounters_without_install_time", "alt": "Testzertifikat Bild 1 von 6" },
{ "filename": "/assets/screenshots/2-7/de/android/RequestCovidCertificateFragment_pcr", "alt": "Testzertifikat Bild 2 von 6" },
Expand Down