feat: adding support for multiframe metadata in wadors and wadouri #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-wado-image-loader ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
reviewed
Dec 1, 2022
sedghi
reviewed
Dec 1, 2022
sedghi
reviewed
Dec 1, 2022
sedghi
reviewed
Dec 1, 2022
sedghi
reviewed
Dec 1, 2022
Closed
wayfarer3130
reviewed
Jan 5, 2023
wayfarer3130
reviewed
Jan 5, 2023
wayfarer3130
reviewed
Jan 5, 2023
wayfarer3130
reviewed
Jan 5, 2023
|
Generally looks ok - a couple of smaller comments, but mostly looks like it should work. As datasets get bigger, it may be useful optimizing the combine so that it does a lazy combine as required, or perhaps caches the result. |
sedghi
reviewed
Jan 6, 2023
sedghi
reviewed
Jan 6, 2023
rodrigobasilio2022
force-pushed
the
feat/multiframe_new
branch
from
08f8d98 to
21d872b
Compare
sedghi
force-pushed
the
feat/multiframe_new
branch
from
f67dedd to
6d9f497
Compare
rodrigobasilio2022
force-pushed
the
feat/multiframe_new
branch
from
6d9f497 to
3ce0cbf
Compare
sedghi
changed the title
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the wado loader to work with multi-frame images.
It changes the metadataManager.js and expects imageids with frames/1, frames/2, indicating the frame needed.
The function to convert a list of multiframe imageids to a list of imageids with frame number can be found in the /utils/demo/helpers/convertMultiframeImageIds.js in a PR of cornerstone-beta