Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added voiLUTFunction #476

Conversation

Ouwen
Copy link
Contributor

@Ouwen Ouwen commented Sep 22, 2022

This is to support voiLUTFunction in cornerstonejs/cornerstone3D#224

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for cornerstone-wado-image-loader ready!

Name Link
🔨 Latest commit ac0d164
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/6379acfbc4d31000092e07ca
😎 Deploy Preview https://deploy-preview-476--cornerstone-wado-image-loader.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ouwen
Copy link
Contributor Author

Ouwen commented Sep 22, 2022

@sedghi

@sedghi
Copy link
Member

sedghi commented Sep 23, 2022

This looks good but the build is failing and doesn't seem like it is your PR

4:12:22 PM: Installing NPM modules using NPM version 8.15.0
4:12:22 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
4:12:22 PM: npm WARN config location in the cache, and they are managed by
4:12:22 PM: npm WARN config     [`cacache`](http://npm.im/cacache).
4:12:22 PM: npm WARN config tmp This setting is no longer used.  npm stores temporary files in a special
4:12:22 PM: npm WARN config location in the cache, and they are managed by
4:12:22 PM: npm WARN config     [`cacache`](http://npm.im/cacache).
4:12:24 PM: npm ERR! code ERESOLVE
4:12:24 PM: npm ERR! ERESOLVE could not resolve
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! While resolving: [email protected]
4:12:24 PM: npm ERR! Found: [email protected]
4:12:24 PM: npm ERR! node_modules/webpack
4:12:24 PM: npm ERR!   dev webpack@"^5.51.2" from the root project
4:12:24 PM: npm ERR!   peer webpack@">=2" from [email protected]
4:12:24 PM: npm ERR!   node_modules/babel-loader
4:12:24 PM: npm ERR!     dev babel-loader@"^8.2.2" from the root project
4:12:24 PM: npm ERR!   11 more (clean-webpack-plugin, copy-webpack-plugin, ...)
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! Could not resolve dependency:
4:12:24 PM: npm ERR! peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from [email protected]
4:12:24 PM: npm ERR! node_modules/istanbul-instrumenter-loader
4:12:24 PM: npm ERR!   dev istanbul-instrumenter-loader@"^3.0.1" from the root project
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! Conflicting peer dependency: [email protected]
4:12:24 PM: npm ERR! node_modules/webpack
4:12:24 PM: npm ERR!   peer webpack@"^2.0.0 || ^3.0.0 || ^4.0.0" from [email protected]
4:12:24 PM: npm ERR!   node_modules/istanbul-instrumenter-loader
4:12:24 PM: npm ERR!     dev istanbul-instrumenter-loader@"^3.0.1" from the root project
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! Fix the upstream dependency conflict, or retry
4:12:24 PM: npm ERR! this command with --force, or --legacy-peer-deps
4:12:24 PM: npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
4:12:24 PM: npm ERR!
4:12:24 PM: npm ERR! See /opt/buildhome/.npm/eresolve-report.txt for a full report.
4:12:24 PM: npm ERR! A complete log of this run can be found in:
4:12:24 PM: npm ERR!     /opt/buildhome/.npm/_logs/2022-09-23T20_12_22_803Z-debug-0.log
4:12:24 PM: Error during NPM install
4:12:24 PM: Build was terminated: Build script returned non-zero exit co

@Ouwen
Copy link
Contributor Author

Ouwen commented Sep 23, 2022

I had this issue as well and needed to yarn install instead of npm install

@Ouwen Ouwen force-pushed the gradienthealth/add_voiLUTFunction branch from 5dda67a to ac0d164 Compare November 20, 2022 04:28
@sedghi sedghi merged commit df47a2a into cornerstonejs:master Dec 1, 2022
@ohif-bot
Copy link
Contributor

ohif-bot commented Dec 1, 2022

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants