-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy buffer to prevent oom in workers #454
Conversation
Large uncompressed multiframe data will send the full arraybuffer in a typed view. For large uncompressed data such as tomo these will result in OOM issues. This fix pre-slices the typed array view so only used buffer is sent via worker.postMessage.
✅ Deploy Preview for cornerstone-wado-image-loader ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The preview is not loading for me:
|
How can I use this solution to handle out of memory Problem ? |
Thanks @Ouwen! This solves a big problem and we definitely want it merged. Some feedback before we can merge this, though:
Tagging @jmannau because he's asked about this in Slack. |
The fix works great for me in the given example with a 293 slice US |
Hello, this is a great PR as it solves our problem. |
Hi all, |
🎉 This PR is included in version 4.13.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Large uncompressed multiframe data will send the full arraybuffer in a typed view. For large uncompressed data such as tomo these will result in OOM issues. This fix pre-slices the typed array view so only used buffer is sent via worker.postMessage.
-restored webWorker.js and WebWorkerManager.js to the ones at commit cornerstonejs#454 -modified convolveTask and sleepTask accordingly -modified imports in html ../../dist/cornerstoneWADOImageLoader.bundle.min.js -modified webpack configuration port and static path
Large uncompressed multiframe data will send the full
arraybuffer in a typed view. For large uncompressed data
such as tomo these will result in OOM issues. This fix
pre-slices the typed array view so only used buffer
is sent via worker.postMessage.