fix(ellipticalROI): give default values for cachedStats values to avoid undefined error #1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix:
_createTextBoxContent() function call during rendering sometimes causes undefined error.
Ideal flow would have been, first calculate all values of
cachedStats
and then call the_createTextBoxContent()
function.But in reality, particularly for the initial load, the
_createTextBoxContent()
function is called before thecachedStats
values are calculated.Gave default value: 0, for the
cachedStats
values that are being used by_createTextBoxContent()
.This will prevent
undefined
error until they are correctly caculcated.No