Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StackPrefetch should use the imageLoadPoolManager #1433

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Sep 30, 2021

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@sedghi sedghi requested a review from swederik September 30, 2021 19:58
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #1433 (2237c1c) into master (0e65ba3) will increase coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   19.86%   19.87%   +0.01%     
==========================================
  Files         285      285              
  Lines       10027    10031       +4     
  Branches     2042     2042              
==========================================
+ Hits         1992     1994       +2     
- Misses       6839     6841       +2     
  Partials     1196     1196              
Impacted Files Coverage Δ
src/stackTools/stackPrefetch.js 6.06% <25.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e65ba3...2237c1c. Read the comment docs.

@swederik swederik merged commit fdb0e47 into master Oct 1, 2021
@swederik swederik deleted the fix/stack-prefetch branch October 1, 2021 07:51
@swederik
Copy link
Member

swederik commented Oct 1, 2021

This should close #1428

@dannyrb
Copy link
Member

dannyrb commented Oct 1, 2021

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants