Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use an unnecessary iterator #1419

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

mikehazell
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Simplifies logic for copying an array

  • What is the current behavior? (You can also link to an open issue here)
    unchanged

  • What is the new behavior (if this is a feature change)?
    unchanged

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1419 (1d19165) into master (41352cc) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
+ Coverage   19.86%   19.88%   +0.01%     
==========================================
  Files         286      286              
  Lines       10133    10124       -9     
  Branches     2068     2067       -1     
==========================================
  Hits         2013     2013              
+ Misses       6913     6905       -8     
+ Partials     1207     1206       -1     
Impacted Files Coverage Δ
...dules/segmentationModule/getSegmentsOnPixeldata.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41352cc...1d19165. Read the comment docs.

@swederik swederik merged commit 95c3b7c into cornerstonejs:master Nov 9, 2021
@swederik
Copy link
Member

swederik commented Nov 9, 2021

Thanks!

(cc @igoroctaviano)

@dannyrb
Copy link
Member

dannyrb commented Nov 9, 2021

🎉 This PR is included in version 6.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikehazell mikehazell deleted the patch-1 branch November 9, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants