feat(imageIdSpecificStateManager): add set imageIdToolState function
#1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
+ Coverage 19.53% 19.58% +0.05%
==========================================
Files 286 286
Lines 10120 10128 +8
Branches 2065 2066 +1
==========================================
+ Hits 1977 1984 +7
- Misses 6930 6931 +1
Partials 1213 1213
Continue to review full report at Codecov.
|
…ctions There is currently no function to consume the same output from getImageIdToolState, which is the state of a specific tool for the given imageId. addElementToolState requires a single item input, and without replace, requires both a clear step and an iteration over all items to add into the tool's id-specific state.
mix3d
force-pushed
the
feature/replaceToolState
branch
from
cd05ac4 to
3650e05
Compare
kevinleedrum
approved these changes
Dec 17, 2020
|
@dannyrb ? |
|
Can we call it |
mix3d
changed the title
replace imageIdToolState functionset imageIdToolState function
|
@swederik renamed functions. Once the test pass I'll merge it. |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A function to replace the tool-specific tool state in the imageId toolstate global manager.
What is the current behavior? (You can also link to an open issue here)
There is currently no function to consume the same output from
getImageIdToolState(), (an object like{'data':[...]}) which is the state of a specific tool for the given imageId.addElementToolState()requires a single item input,and without a replace function, requires both a
clearImageIdToolState()step and an iteration over all items to add into the tool's id-specific state, or restoring the ENTIRE imageId tool state manager with data from ALL tools.What is the new behavior (if this is a feature change)?
New function on the
globalImageIdToolStateManagerobject.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: